Skip to content

[CodeCompletion] Evaluate 'PatternBindingEntryRequest' before checking the init #28949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2020
Merged

[CodeCompletion] Evaluate 'PatternBindingEntryRequest' before checking the init #28949

merged 1 commit into from
Jan 2, 2020

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Dec 26, 2019 •
edited
Loading

If a completion happens in a PatternBindingInitializer context for TypedPattern without any VarDecl, e.g.:

let _: Int = <HERE>

it crashes because typeCheckPatternBinding() requires that the TypedPattern has the type.

rdar://problem/52105899

@rintaro
[CodeCompletion] Evaluate 'PatternBindingEntry' before checking the init
091c36b 
If a completion happens in an 'PatternBindingInitializer' context for
'TypedPattern' without any 'VarDecl', e.g.:

    let _: Int = <COMPLETION>

it crashes because 'typeCheckPatternBinding()' requires that the
'TypedPattern' has the type.

rdar://problem/52105899
@rintaro
Copy link
Member Author

rintaro commented Dec 26, 2019

@swift-ci Please smoke test

@rintaro rintaro changed the title [CodeCompletion] Evaluate 'PatternBindingEntry' before checking the init [CodeCompletion] Evaluate 'PatternBindingEntryRequest' before checking the init Dec 26, 2019
CodaFi
CodaFi approved these changes Jan 2, 2020
View reviewed changes
Copy link
Contributor

@CodaFi CodaFi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully I can come back around here and requestify TypeChecker::typeCheckPatternBinding then provide a high-level "type check this whole pattern binding" request so this doesn't happen again.

@rintaro rintaro merged commit 9cd3072 into swiftlang:master Jan 2, 2020
@rintaro rintaro mentioned this pull request Jan 2, 2020
Merged
@rintaro rintaro deleted the ide-completion-rdar52105899 branch January 13, 2020 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodaFi CodaFi CodaFi approved these changes

@slavapestov slavapestov Awaiting requested review from slavapestov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rintaro @CodaFi