Sema: Don't mark property wrapper 'modify' accessors transparent [5.2] #28987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are certain conditions that cause them to reference non-public properties, in particular if the property wrapper is implemented via a subscript taking a keypath. Instead of trying to detect this specific case though (and possibly missing others), I'm just going to decree that 'modify' is never going to be transparent for property wrappers. Fixes <rdar://problem/57609867>.
|
@swift-ci Please test |
|
@DougGregor is this OK for 5.2? |
|
Build failed |
|
@swift-ci Please test macOS |
|
Build failed |
|
@swift-ci Please test macOS |
|
Build failed |
DougGregor
approved these changes
Jan 3, 2020
|
@swift-ci Please test macOS |
DougGregor
approved these changes
Jan 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are certain conditions that cause them to reference
non-public properties, in particular if the property
wrapper is implemented via a subscript taking a keypath.
Instead of trying to detect this specific case though (and
possibly missing others), I'm just going to decree that
'modify' is never going to be transparent for property
wrappers.
Fixes rdar://problem/57609867.