[semantic-arc-opts] When performing load [copy] -> load_borrow on classes, do not ignore forwarding uses. #28989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
Build failed |
|
Thanks for tracking this down! |
|
@swift-ci test os x platform |
|
I started to play with this a bit locally, and I found a smaller simpler change to cherry-pick. I am going to first commit that. |
|
I tried to cherry-pick this change and I found it to be a bit difficult since the LiveRange infrastructure doesn't exist on 5.2. I am about to push an even smaller fix that only uses things in that older code to make it slightly easier to cherry-pick. In a subsequent PR, I am going to re-add the LiveRange code. |
gottesmm
force-pushed
the
pr-42b06814f186ae88911b84b21640d36b25c7a1cd
branch
from
eb0e969 to
26af4ab
Compare
gottesmm
changed the title
|
@swift-ci test |
…sses, do not ignore forwarding uses. This is the first of two commits. This commit is a very simple, easily cherry-pickable fix but does not use the LiveRange infrastructure so that we handle forwarding uses here. Instead, we just bail if all uses of our load [copy] are not destroy_value. In a subsequent commit, I am going to change this to use the LiveRange infrastructure so we will handle these cases. Sadly doing so doesn't cherry-pick well. = /. rdar://58289320
gottesmm
force-pushed
the
pr-42b06814f186ae88911b84b21640d36b25c7a1cd
branch
from
26af4ab to
23f36a0
Compare
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
Build failed |
|
Java failure... |
|
@swift-ci test os x platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise in cases like the test case attached, we will not properly look
through the destroy.
In a subsequent commit, I am going to do some more fixes here by adding memory
use verification around begin_borrow. I have wanted to enable this for a minute,
but this seems like a good time to do so given that would have caught this.
rdar://58289320
EDIT! I am doing a smaller cherry-picking fix. I am still using this PR to not confuse the automation. See message below in conversation!