[NFC] Hide SourceFile::Decls #28995
Merged
[NFC] Hide SourceFile::Decls #28995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test and merge |
|
Nice! |
slavapestov
approved these changes
Jan 3, 2020
| /// The list of top-level declarations in the source file. | ||
| std::vector<Decl*> Decls; | ||
| /// Appends the given declaration to the end of the top-level decls list. | ||
| void addTopLevelDecl(Decl *d) { |
There was a problem hiding this comment.
Eventually this should set them all in one shot so that anything depending on getTopLevelDecls() is immutable.
There was a problem hiding this comment.
LLDB is going to be the last bastion of mutations here...
|
Urf, need LLDB patches. |
|
@swift-ci smoke test |
In preparation for installing some stable paths infrastructure here, hide access to the array of top-level decls.
CodaFi
force-pushed
the
absolutely-path-ological
branch
from
7bd03f0 to
96b3b9f
Compare
|
@swift-ci smoke test |
CodaFi
added a commit
to CodaFi/llvm-project
that referenced
this pull request
Jan 6, 2020
|
@swift-ci smoke test |
SwiftASTManipulator is installing declarations in the wrong order, and currently fails a REPL test if the right API is used. rdar://58355191 is tracking the removal of this entrypoint.
|
Installed a workaround for LLDB and filed rdar://58355191 about removing it on their end. |
|
@swift-ci smoke test |
|
⛵️ |
adrian-prantl
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Jan 8, 2020
Supports swiftlang/swift#28995 (cherry picked from commit f64e25b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for installing some stable paths infrastructure here,
hide access to the array of top-level decls.