[ConstraintSystem] Finish porting unresolved member reference failures. #29000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
hborla
commented
Jan 3, 2020
| @@ -251,7 +251,8 @@ struct Toe { | |||
| let toenail: Nail // expected-error {{use of undeclared type 'Nail'}} | |||
|
|
|||
| func clip() { | |||
| toenail.inspect { x in | |||
| // FIXME: We shouldn't report this because toenail.inspect is a hole | |||
| toenail.inspect { x in // expected-error {{unable to infer closure return type; add explicit type to disambiguate}} | |||
There was a problem hiding this comment.
We can fix this by using applicable function constraint to bind hole types to the correct shape
xedin
approved these changes
Jan 4, 2020
| @@ -805,11 +805,12 @@ class UseSubscriptOperator final : public ConstraintFix { | |||
| class DefineMemberBasedOnUse final : public ConstraintFix { | |||
| Type BaseType; | |||
| DeclNameRef Name; | |||
| bool AlreadyDiagnosed; | |||
There was a problem hiding this comment.
Nit: Would you mind adding a comment about why this is necessary for posterity?
This covers member failures where the error is at the declaration, so the result of member lookup is "already diagnosed".
hborla
force-pushed
the
unresolved-member-expr-diagnostics
branch
from
a3af84c to
94bbb8f
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers member failures where the error is at the declaration, so the result of member lookup is "already diagnosed".
We record references to erroneous member declarations as a hole in order to allow the constraint solver to continue, and to suppress diagnostics at the site of the reference (since the error is already diagnosed at the declaration).
Note: We need to record and diagnose at least one fix in order to solve the constraint system in the new diagnostic infrastructure. For this reason, we record the
DefineMemberBasedOnUsefix for erroneous members, but flag the fix as "already diagnosed" to suppress the error message.