Skip to content

[AutoDiff] Upstream minor changes from tensorflow branch. #29018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2020

Conversation

dan-zheng
Copy link
Contributor

Upstream derivative function lookup changes from #28935.

Upstream derivative function lookup changes from
swiftlang#28935.
@@ -3182,20 +3182,15 @@ static AbstractFunctionDecl *findAbstractFunctionDecl(

// Perform lookup.
LookupResult results;
// If `baseType` is not null but `lookupContext` is a type context, set
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this change is mostly NFC. I failed to find a minimal reproducer for the fixed issue TF-1090 in #28935, though I didn't try very hard. I think no test on master is fine.

@dan-zheng dan-zheng requested a review from rxwei January 6, 2020 07:38
@dan-zheng
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Jan 6, 2020

Build failed
Swift Test OS X Platform
Git Sha - a943699

@dan-zheng
Copy link
Contributor Author

@swift-ci Please test macOS

@dan-zheng dan-zheng merged commit 8bd3e2d into swiftlang:master Jan 6, 2020
@dan-zheng dan-zheng deleted the autodiff-upstream branch January 6, 2020 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants