[5.2][semantic-arc-opts] When performing load [copy] -> load_borrow on classes, do not ignore forwarding uses. #29034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sses, do not ignore forwarding uses. This is the first of two commits. This commit is a very simple, easily cherry-pickable fix but does not use the LiveRange infrastructure so that we handle forwarding uses here. Instead, we just bail if all uses of our load [copy] are not destroy_value. In a subsequent commit, I am going to change this to use the LiveRange infrastructure so we will handle these cases. Sadly doing so doesn't cherry-pick well. = /. rdar://58289320 (cherry picked from commit 23f36a0)
|
@swift-ci test |
airspeedswift
approved these changes
Jan 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of two commits. This commit is a very simple, easily
cherry-pickable fix but does not use the LiveRange infrastructure so that we
handle forwarding uses here. Instead, we just bail if all uses of our load
[copy] are not destroy_value.
In a subsequent commit, I am going to change this to use the LiveRange
infrastructure so we will handle these cases. Sadly doing so doesn't cherry-pick
well. = /.
rdar://58289320
(cherry picked from commit 23f36a0)
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.