Skip to content

[5.2][Serialization] Recover from deserializing an enum from a missing module #29044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2020

Conversation

xymus
Copy link
Contributor

@xymus xymus commented Jan 7, 2020

Cherry-picked from #28911.

This is a quick fix for a deserialization failure of an enum defined behind an @_implementationOnly import. The failure was trigger in a lookup path, so dropping the enum shouldn't be an issue.

rdar://problem/58022345

@xymus xymus requested a review from nkcsgexi January 7, 2020 19:14
@xymus xymus requested a review from a team as a code owner January 7, 2020 19:14
@xymus
Copy link
Contributor Author

xymus commented Jan 7, 2020

@swift-ci Please test

Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the 5.2 branch

@xymus xymus merged commit 5e3a6ac into swiftlang:swift-5.2-branch Jan 8, 2020
@xymus xymus deleted the rdar58022345-5.2 branch January 8, 2020 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants