[Basic] Disable body of broken Located<T>::dump() method
#29045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer clangs are more reliable about emitting templated methods that are marked "used".
|
@swift-ci please smoke test and merge |
|
Can you comment out/remove the method entirely if it is not being used anywhere? |
|
I could. That would require changing the header too. This seemed easier and less churn (and noise in the git-blame history). Besides, I assume that we want the |
|
Also, dump() methods are supposed to not be "used" anywhere (except interactively while debugging the compiler). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer clangs are more reliable about emitting templated methods that are marked "used".