Skip to content

[Experiment] Unblock lazy member loading for globals-as-members #29051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[Experiment] Unblock lazy member loading for globals-as-members #29051

wants to merge 2 commits into from

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Jan 7, 2020

The successor to #29007.

Because we need two of everything.

⚠️ DO NOT MERGE ⚠️

@CodaFi
Copy link
Contributor Author

CodaFi commented Jan 7, 2020

@swift-ci test

@CodaFi
Copy link
Contributor Author

CodaFi commented Jan 7, 2020

@swift-ci test compiler performance

@CodaFi
Copy link
Contributor Author

CodaFi commented Jan 7, 2020

@swift-ci test source compatibility

@swift-ci
Copy link
Contributor

swift-ci commented Jan 8, 2020

Summary for master full

Unexpected test results, excluded stats for RxCocoa, SwifterSwift, Base64CoderSwiftUI

No regressions above thresholds

Debug-batch

debug-batch brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (3)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 50,791,565,193,655 50,605,633,226,608 -185,931,967,047 -0.37%
LLVM.NumLLVMBytesOutput 1,801,511,792 1,801,526,914 15,122 0.0%
time.swift-driver.wall 5500.2s 5516.0s 15.8s 0.29%

debug-batch detailed

Regressed (0)
name old new delta delta_pct
Improved (9)
name old new delta delta_pct
AST.ModuleShadowCacheHit 1,533,528 1,489,331 -44,197 -2.88% ✅
AST.NumTotalClangImportedEntities 6,199,919 6,082,476 -117,443 -1.89% ✅
Driver.NumDriverPipePolls 78,497 77,271 -1,226 -1.56% ✅
Driver.NumDriverPipeReads 65,932 64,824 -1,108 -1.68% ✅
Sema.CollectOverriddenDeclsRequest 7,404,382 7,325,981 -78,401 -1.06% ✅
Sema.IsStaticRequest 3,728,852 3,656,404 -72,448 -1.94% ✅
Sema.NamedLazyMemberLoadFailureCount 17,600 15,165 -2,435 -13.84% ✅
Sema.ProvideDefaultImplForRequest 7,404,382 7,325,981 -78,401 -1.06% ✅
Sema.QualifiedLookupRequest 7,371,759 7,288,033 -83,726 -1.14% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (199)
name old new delta delta_pct
AST.ImportSetCacheHit 1,809,762 1,808,853 -909 -0.05%
AST.ImportSetCacheMiss 1,119,090 1,118,912 -178 -0.02%
AST.ImportSetFoldHit 650,142 650,052 -90 -0.01%
AST.ImportSetFoldMiss 468,948 468,860 -88 -0.02%
AST.ModuleShadowCacheMiss 13,567 13,534 -33 -0.24%
AST.ModuleVisibilityCacheHit 33,149 33,149 0 0.0%
AST.ModuleVisibilityCacheMiss 8,458 8,458 0 0.0%
AST.NumASTBytesAllocated 64,504,993,228 64,367,460,042 -137,533,186 -0.21%
AST.NumASTScopeLookups 4,290,105 4,289,644 -461 -0.01%
AST.NumBraceStmtASTScopeExpansions 624,906 624,906 0 0.0%
AST.NumBraceStmtASTScopes 624,906 624,906 0 0.0%
AST.NumDecls 139,853 139,853 0 0.0%
AST.NumDependencies 429,001 429,011 10 0.0%
AST.NumInfixOperators 53,695 53,695 0 0.0%
AST.NumIterableTypeBodyASTScopeExpansions 271,590 271,577 -13 -0.0%
AST.NumIterableTypeBodyASTScopes 355,208 355,079 -129 -0.04%
AST.NumLinkLibraries 0 0 0 0.0%
AST.NumLoadedModules 404,163 404,163 0 0.0%
AST.NumLocalTypeDecls 250 250 0 0.0%
AST.NumModuleLookupClassMember 6,927 6,927 0 0.0%
AST.NumModuleLookupValue 48,543,585 48,512,778 -30,807 -0.06%
AST.NumObjCMethods 24,240 24,240 0 0.0%
AST.NumPostfixOperators 49 49 0 0.0%
AST.NumPrecedenceGroups 25,840 25,840 0 0.0%
AST.NumPrefixOperators 99 99 0 0.0%
AST.NumReferencedDynamicNames 189 189 0 0.0%
AST.NumReferencedMemberNames 6,309,732 6,309,732 0 0.0%
AST.NumReferencedTopLevelNames 476,243 476,243 0 0.0%
AST.NumSourceBuffers 602,301 602,301 0 0.0%
AST.NumSourceLines 4,717,684 4,717,684 0 0.0%
AST.NumSourceLinesPerSecond 3,270,166 3,268,036 -2,130 -0.07%
Driver.ChildrenMaxRSS 242,643,351,552 242,366,359,552 -276,992,000 -0.11%
Driver.DriverDepCascadingDynamic 0 0 0 0.0%
Driver.DriverDepCascadingExternal 0 0 0 0.0%
Driver.DriverDepCascadingMember 0 0 0 0.0%
Driver.DriverDepCascadingNominal 0 0 0 0.0%
Driver.DriverDepCascadingTopLevel 0 0 0 0.0%
Driver.DriverDepDynamic 0 0 0 0.0%
Driver.DriverDepExternal 0 0 0 0.0%
Driver.DriverDepMember 0 0 0 0.0%
Driver.DriverDepNominal 0 0 0 0.0%
Driver.DriverDepTopLevel 0 0 0 0.0%
Driver.NumDriverJobsRun 28,030 28,030 0 0.0%
Driver.NumDriverJobsSkipped 0 0 0 0.0%
Driver.NumProcessFailures 0 0 0 0.0%
Frontend.MaxMallocUsage 1,231,947,198,400 1,229,415,370,760 -2,531,827,640 -0.21%
Frontend.NumInstructionsExecuted 50,791,565,193,655 50,605,633,226,608 -185,931,967,047 -0.37%
Frontend.NumProcessFailures 0 0 0 0.0%
IRModule.NumIRAliases 196,319 196,319 0 0.0%
IRModule.NumIRBasicBlocks 6,863,346 6,863,346 0 0.0%
IRModule.NumIRComdatSymbols 0 0 0 0.0%
IRModule.NumIRFunctions 3,371,916 3,371,916 0 0.0%
IRModule.NumIRGlobals 3,682,366 3,682,366 0 0.0%
IRModule.NumIRIFuncs 0 0 0 0.0%
IRModule.NumIRInsts 87,970,348 87,970,348 0 0.0%
IRModule.NumIRNamedMetaData 135,380 135,380 0 0.0%
IRModule.NumIRValueSymbols 6,399,165 6,399,165 0 0.0%
LLVM.NumLLVMBytesOutput 1,801,511,792 1,801,526,914 15,122 0.0%
Parse.NumFunctionsParsed 268,976 268,976 0 0.0%
Parse.NumIterableDeclContextParsed 939,426 939,393 -33 -0.0%
Parse.ParseAbstractFunctionBodyRequest 246,370 246,370 0 0.0%
Parse.ParseMembersRequest 770,802 770,769 -33 -0.0%
SILModule.NumSILGenDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILGenFunctions 1,701,394 1,701,394 0 0.0%
SILModule.NumSILGenGlobalVariables 53,554 53,554 0 0.0%
SILModule.NumSILGenVtables 18,627 18,627 0 0.0%
SILModule.NumSILGenWitnessTables 72,395 72,395 0 0.0%
SILModule.NumSILOptDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILOptFunctions 2,523,223 2,523,223 0 0.0%
SILModule.NumSILOptGlobalVariables 55,187 55,187 0 0.0%
SILModule.NumSILOptVtables 31,428 31,428 0 0.0%
SILModule.NumSILOptWitnessTables 169,304 169,304 0 0.0%
Sema.AbstractGenericSignatureRequest 34,854 34,854 0 0.0%
Sema.AccessLevelRequest 12,427,885 12,374,603 -53,282 -0.43%
Sema.AnyObjectLookupRequest 281 281 0 0.0%
Sema.AreAllStoredPropertiesDefaultInitableRequest 23,241 23,241 0 0.0%
Sema.AttachedFunctionBuilderRequest 3 3 0 0.0%
Sema.AttachedPropertyWrapperTypeRequest 540,381 540,381 0 0.0%
Sema.AttachedPropertyWrappersRequest 2,374,806 2,374,803 -3 -0.0%
Sema.CallerSideDefaultArgExprRequest 78,637 78,637 0 0.0%
Sema.ClassAncestryFlagsRequest 111,574 111,574 0 0.0%
Sema.CompareDeclSpecializationRequest 471,754 470,177 -1,577 -0.33%
Sema.CursorInfoRequest 0 0 0 0.0%
Sema.CustomAttrNominalRequest 3 3 0 0.0%
Sema.DefaultAndMaxAccessLevelRequest 58,487 58,491 4 0.01%
Sema.DefaultArgumentExprRequest 38,177 38,177 0 0.0%
Sema.DefaultArgumentInitContextRequest 454 454 0 0.0%
Sema.DefaultDefinitionTypeRequest 8,214 8,214 0 0.0%
Sema.DefaultTypeRequest 455,957 455,957 0 0.0%
Sema.DynamicallyReplacedDeclRequest 1,069,474 1,069,474 0 0.0%
Sema.EmittedMembersRequest 27,960 27,960 0 0.0%
Sema.EnumRawTypeRequest 25,725 25,725 0 0.0%
Sema.EnumRawValuesRequest 10,587 10,587 0 0.0%
Sema.ExistentialConformsToSelfRequest 14,507 14,459 -48 -0.33%
Sema.ExistentialTypeSupportedRequest 17,897 17,897 0 0.0%
Sema.ExpandASTScopeRequest 7,675,264 7,675,047 -217 -0.0%
Sema.ExtendedNominalRequest 916,704 916,704 0 0.0%
Sema.ExtendedTypeRequest 83,500 83,495 -5 -0.01%
Sema.FunctionBuilderTypeRequest 3 3 0 0.0%
Sema.FunctionOperatorRequest 73,361 73,361 0 0.0%
Sema.GenericParamListRequest 12,857,921 12,799,481 -58,440 -0.45%
Sema.GenericSignatureRequest 5,656,530 5,635,676 -20,854 -0.37%
Sema.GetDestructorRequest 28,229 28,229 0 0.0%
Sema.HasCircularInheritanceRequest 23,920 23,920 0 0.0%
Sema.HasCircularInheritedProtocolsRequest 10,224 10,224 0 0.0%
Sema.HasCircularRawValueRequest 8,958 8,958 0 0.0%
Sema.HasDefaultInitRequest 56,884 56,884 0 0.0%
Sema.HasDynamicMemberLookupAttributeRequest 711,646 711,392 -254 -0.04%
Sema.HasMemberwiseInitRequest 20,394 20,394 0 0.0%
Sema.HasMissingDesignatedInitializersRequest 26,847 26,836 -11 -0.04%
Sema.HasUserDefinedDesignatedInitRequest 56,894 56,894 0 0.0%
Sema.InferredGenericSignatureRequest 189,628 189,609 -19 -0.01%
Sema.InheritedDeclsReferencedRequest 6,940,674 6,897,024 -43,650 -0.63%
Sema.InheritedTypeRequest 314,887 314,582 -305 -0.1%
Sema.InheritsSuperclassInitializersRequest 30,032 30,005 -27 -0.09%
Sema.InitKindRequest 98,033 98,033 0 0.0%
Sema.InterfaceTypeRequest 17,027,054 16,957,727 -69,327 -0.41%
Sema.IsABICompatibleOverrideRequest 136,210 136,210 0 0.0%
Sema.IsAccessorTransparentRequest 319,462 319,462 0 0.0%
Sema.IsCallableNominalTypeRequest 2,089 2,089 0 0.0%
Sema.IsDeclApplicableRequest 0 0 0 0.0%
Sema.IsDynamicRequest 1,753,080 1,753,080 0 0.0%
Sema.IsFinalRequest 2,675,608 2,667,747 -7,861 -0.29%
Sema.IsGetterMutatingRequest 434,466 434,466 0 0.0%
Sema.IsImplicitlyUnwrappedOptionalRequest 2,527,339 2,523,655 -3,684 -0.15%
Sema.IsObjCRequest 1,599,234 1,599,190 -44 -0.0%
Sema.IsSetterMutatingRequest 342,898 342,898 0 0.0%
Sema.LazyStoragePropertyRequest 2,516 2,516 0 0.0%
Sema.LookupInModuleRequest 6,824,151 6,799,151 -25,000 -0.37%
Sema.LookupPrecedenceGroupRequest 175,955 175,955 0 0.0%
Sema.MangleLocalTypeDeclRequest 500 500 0 0.0%
Sema.ModuleQualifiedLookupRequest 3,010,399 2,985,842 -24,557 -0.82%
Sema.NamedLazyMemberLoadSuccessCount 12,872,098 12,873,365 1,267 0.01%
Sema.NamingPatternRequest 207,681 207,678 -3 -0.0%
Sema.NeedsNewVTableEntryRequest 696,060 696,060 0 0.0%
Sema.NominalTypeLookupDirectCount 34,700,761 34,572,663 -128,098 -0.37%
Sema.NumAccessorBodiesSynthesized 189,152 189,152 0 0.0%
Sema.NumAccessorsSynthesized 295,089 295,089 0 0.0%
Sema.NumConformancesDeserialized 9,732,900 9,707,723 -25,177 -0.26%
Sema.NumConstraintScopes 27,685,818 27,681,666 -4,152 -0.01%
Sema.NumConstraintsConsideredForEdgeContraction 92,819,512 92,817,670 -1,842 -0.0%
Sema.NumCyclicOneWayComponentsCollapsed 0 0 0 0.0%
Sema.NumDeclsDeserialized 77,504,810 77,253,735 -251,075 -0.32%
Sema.NumDeclsTypechecked 1,412,011 1,412,011 0 0.0%
Sema.NumFunctionsTypechecked 529,260 529,260 0 0.0%
Sema.NumGenericSignatureBuilders 1,465,145 1,464,100 -1,045 -0.07%
Sema.NumLazyIterableDeclContexts 9,825,639 9,812,233 -13,406 -0.14%
Sema.NumLazyRequirementSignatures 1,043,871 1,043,796 -75 -0.01%
Sema.NumLazyRequirementSignaturesLoaded 753,386 753,234 -152 -0.02%
Sema.NumLeafScopes 17,645,731 17,642,544 -3,187 -0.02%
Sema.NumTypesDeserialized 23,794,880 23,758,491 -36,389 -0.15%
Sema.NumTypesValidated 1,526,785 1,526,776 -9 -0.0%
Sema.NumUnloadedLazyIterableDeclContexts 6,291,856 6,290,949 -907 -0.01%
Sema.OpaqueReadOwnershipRequest 282,056 282,056 0 0.0%
Sema.OpaqueResultTypeRequest 0 0 0 0.0%
Sema.OperatorPrecedenceGroupRequest 747 747 0 0.0%
Sema.OverriddenDeclsRequest 3,052,899 3,035,052 -17,847 -0.58%
Sema.ParamSpecifierRequest 1,309,282 1,309,276 -6 -0.0%
Sema.PatternBindingEntryRequest 464,935 464,932 -3 -0.0%
Sema.PatternTypeRequest 586,250 586,247 -3 -0.0%
Sema.PreCheckFunctionBuilderRequest 0 0 0 0.0%
Sema.PropertyWrapperBackingPropertyInfoRequest 535,004 535,004 0 0.0%
Sema.PropertyWrapperBackingPropertyTypeRequest 540,381 540,381 0 0.0%
Sema.PropertyWrapperMutabilityRequest 630,613 630,613 0 0.0%
Sema.PropertyWrapperTypeInfoRequest 1 1 0 0.0%
Sema.ProtocolRequiresClassRequest 76,416 75,764 -652 -0.85%
Sema.RangeInfoRequest 0 0 0 0.0%
Sema.RequirementRequest 113,864 113,859 -5 -0.0%
Sema.RequirementSignatureRequest 833,091 832,614 -477 -0.06%
Sema.RequiresOpaqueAccessorsRequest 1,314,548 1,314,548 0 0.0%
Sema.RequiresOpaqueModifyCoroutineRequest 273,195 273,195 0 0.0%
Sema.ResilienceExpansionRequest 1,865,565 1,865,542 -23 -0.0%
Sema.ResolveImplicitMemberRequest 373,365 373,471 106 0.03%
Sema.ResolveProtocolNameRequest 0 0 0 0.0%
Sema.ResultTypeRequest 695,560 695,548 -12 -0.0%
Sema.RootAndResultTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.RootTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.SelfAccessKindRequest 3,175,673 3,163,323 -12,350 -0.39%
Sema.SelfBoundsFromWhereClauseRequest 1,814,596 1,805,365 -9,231 -0.51%
Sema.SetterAccessLevelRequest 145,111 145,111 0 0.0%
Sema.StorageImplInfoRequest 1,423,621 1,423,621 0 0.0%
Sema.StoredPropertiesAndMissingMembersRequest 32,428 32,428 0 0.0%
Sema.StoredPropertiesRequest 369,964 369,964 0 0.0%
Sema.StructuralTypeRequest 2,318 2,318 0 0.0%
Sema.SuperclassDeclRequest 501,309 500,980 -329 -0.07%
Sema.SuperclassTypeRequest 60,087 60,087 0 0.0%
Sema.SynthesizeAccessorRequest 295,089 295,089 0 0.0%
Sema.SynthesizeDefaultInitRequest 5,394 5,394 0 0.0%
Sema.SynthesizeMemberwiseInitRequest 3,199 3,199 0 0.0%
Sema.TypeCheckFunctionBodyUntilRequest 529,260 529,260 0 0.0%
Sema.TypeCheckSourceFileRequest 27,076 27,076 0 0.0%
Sema.TypeDeclsFromWhereClauseRequest 30,489 30,493 4 0.01%
Sema.TypeRelationCheckRequest 0 0 0 0.0%
Sema.TypeWitnessRequest 9,279 9,275 -4 -0.04%
Sema.USRGenerationRequest 8,803,001 8,717,895 -85,106 -0.97%
Sema.UnderlyingTypeDeclsReferencedRequest 382,816 380,322 -2,494 -0.65%
Sema.UnderlyingTypeRequest 38,660 38,660 0 0.0%
Sema.UnqualifiedLookupRequest 4,434,924 4,434,463 -461 -0.01%
Sema.ValueWitnessRequest 68,677 68,677 0 0.0%

Release

release brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (3)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 51,270,555,310,677 51,263,276,751,437 -7,278,559,240 -0.01%
LLVM.NumLLVMBytesOutput 1,926,881,060 1,926,882,508 1,448 0.0%
time.swift-driver.wall 9510.7s 9510.8s 106.4ms 0.0%

release detailed

Regressed (0)
name old new delta delta_pct
Improved (1)
name old new delta delta_pct
AST.NumTotalClangImportedEntities 1,182,860 1,126,674 -56,186 -4.75% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (17)
name old new delta delta_pct
AST.NumLoadedModules 30,053 30,053 0 0.0%
IRModule.NumIRBasicBlocks 5,447,970 5,447,970 0 0.0%
IRModule.NumIRFunctions 2,833,661 2,833,661 0 0.0%
IRModule.NumIRGlobals 3,193,845 3,193,845 0 0.0%
IRModule.NumIRInsts 53,509,026 53,509,026 0 0.0%
IRModule.NumIRValueSymbols 5,670,071 5,670,071 0 0.0%
LLVM.NumLLVMBytesOutput 1,926,881,060 1,926,882,508 1,448 0.0%
SILModule.NumSILGenFunctions 1,189,997 1,189,997 0 0.0%
SILModule.NumSILOptFunctions 1,733,021 1,733,021 0 0.0%
Sema.NumConformancesDeserialized 3,645,246 3,645,206 -40 -0.0%
Sema.NumConstraintScopes 27,313,772 27,313,772 0 0.0%
Sema.NumDeclsDeserialized 10,696,141 10,694,277 -1,864 -0.02%
Sema.NumFunctionsTypechecked 532,882 532,882 0 0.0%
Sema.NumGenericSignatureBuilders 281,445 281,445 0 0.0%
Sema.NumLazyIterableDeclContexts 1,318,546 1,317,380 -1,166 -0.09%
Sema.NumTypesDeserialized 5,413,853 5,413,175 -678 -0.01%
Sema.NumTypesValidated 826,777 826,777 0 0.0%

@CodaFi
Copy link
Contributor Author

CodaFi commented Jan 9, 2020

Alright, let's tidy this up and merge it.

@CodaFi CodaFi closed this Jan 9, 2020
@CodaFi CodaFi deleted the globals-as-members-redo-part-two branch January 9, 2020 05:25
@CodaFi CodaFi mentioned this pull request Jan 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodaFi @swift-ci