swiftMSVCRT: build with -Xcc -D_USE_MATH_DEFINES
#29054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables the use of the math defines when building tgmath.swift. Although not used in the normal branch, this define is necessary to build the swiftMSVCRT module for TensorFlow which uses the math constants.
|
@swift-ci please smoke test |
|
@swift-ci please test Windows platform |
compnerd
changed the title
-Xcc -D_USE_MATH_DEFINES-Xcc -D_USE_MATH_DEFINES
|
@swift-ci please clean test Windows platform |
compnerd
changed the title
-Xcc -D_USE_MATH_DEFINES-Xcc -D_USE_MATH_DEFINES
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the use of the math defines when building tgmath.swift.
Although not used in the normal branch, this define is necessary to
build the swiftMSVCRT module for TensorFlow which uses the math
constants.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.