Remove DelayedDeclLists from PersistentParserState #29071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given `-verify` is used for testing, ideally it shouldn't exhibit different behaviour to an equivalent invocation without it.
Rather than parsing all delayed bodies for `-dump-parse` once we finish parsing, tell the parser not to delay any bodies. This then allows us to remove `DelayedDeclLists` from PersistentParserState.
This better matches the behavior of `parseAndTypeCheckMainFileUpTo`.
`performParseOnly` has been able to handle multiple input files for a while now.
|
@swift-ci please test |
slavapestov
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DelayedDeclListsis currently only used by-verifyand-dump-parseto fully parse the bodies of types which we've previously skipped.For
-verify, avoid doing this as ideally we shouldn't emit any additional parsing diagnostics that an equivalent invocation without-verifywould. For-dump-parse, tell the parser not to delay any bodies.In addition, this PR enables the delayed body parsing for
-parseof a non-primary main file, which better matches the behavior ofparseAndTypeCheckMainFileUpTo.