Skip to content

Change swift-cmark repo when checking out swift-5.1-branch #29081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Change swift-cmark repo when checking out swift-5.1-branch #29081

merged 1 commit into from
Jan 9, 2020

Conversation

futurejones
Copy link
Contributor

A recent change to swift-cmark
swiftlang/swift-cmark#15
has revealed an error in the update-checkout-config.json file.

When running update-checkout --clone --scheme swift-5.1-branch the file incorrectly checks out the master-branch for swift-cmark when it should be checking out the swift-5.1-branch

This is causing swift-5.1-branch builds to fail with this error:-

CMake Error at cmake/modules/SwiftSharedCMakeConfig.cmake:189 (include):
  include could not find load file:

    /home/worksonarm_test/jenkins_slave/workspace/swift-5.1-dev/build/buildbot_linux/cmark-linux-aarch64/src/CMarkExports.cmake

@shahmishal this is what is causing the build fails on https://ci-external.swift.org/view/swift-5.1-branch/job/oss-swift-5.1-RA-linux-ubuntu-16.04-aarch64/

@shahmishal shahmishal merged commit 98a5c04 into swiftlang:master Jan 9, 2020
@shahmishal
Copy link
Member

Thanks!

@futurejones
Copy link
Contributor Author

@shahmishal Thanks!
Would it be possible to add this change to the swift-5.1-branch as well?

@shahmishal
Copy link
Member

Yes, can you cherry-pick it? I will merge it. Thanks!

@futurejones
Copy link
Contributor Author

Added pull request #29087

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants