-
Notifications
You must be signed in to change notification settings - Fork 10.5k
CMake: move tricky code from CMake to Python #2909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@rintaro If you have time, could you review, please? |
@swift-ci Please test |
@swift-ci Please smoke test |
I feel I'm a little puzzled about test feature flags. |
I think doing so would disable them in, for example, |
try: | ||
config.limit_to_features.remove("executable_test") | ||
except: | ||
pass # It is not an error that we didn't remove anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: config.limit_to_features.discard("executable_test")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed!
I see, thank you! |
Removing an abstraction boundary also allowed me to fix a bug where we could not run long tests in optimized mode, which prevented us from being able to mark executable tests as long.
4059747
to
a30f90c
Compare
Thank you for the review! @swift-ci Please smoke test and merge |
[pull] swiftwasm from main
Removing an abstraction boundary also allowed me to fix a bug where we could not run long tests in optimized mode, which prevented us from being able to mark executable tests as long.
I tested this refactoring by running each
check-swift-*-macosx-*
target with--no-execute --show-unsupported
arguments for lit, and inspected the output to make sure that we execute the right tests in each mode.Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.