Skip to content

CMake: move tricky code from CMake to Python #2909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2016
Merged

Conversation

gribozavr
Copy link
Contributor

@gribozavr gribozavr commented Jun 6, 2016

Removing an abstraction boundary also allowed me to fix a bug where we could not run long tests in optimized mode, which prevented us from being able to mark executable tests as long.

I tested this refactoring by running each check-swift-*-macosx-* target with --no-execute --show-unsupported arguments for lit, and inspected the output to make sure that we execute the right tests in each mode.


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
All supported platforms @swift-ci Please smoke test and merge
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
All supported platforms @swift-ci Please test and merge
OS X platform @swift-ci Please test OS X platform
OS X platform @swift-ci Please benchmark
Linux platform @swift-ci Please test Linux platform

Lint Testing

Language Comment
Python @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

@gribozavr
Copy link
Contributor Author

@rintaro If you have time, could you review, please?

@gribozavr
Copy link
Contributor Author

@swift-ci Please test

@gribozavr
Copy link
Contributor Author

@swift-ci Please smoke test

@rintaro
Copy link
Member

rintaro commented Jun 6, 2016

I feel I'm a little puzzled about test feature flags.
I'm pretty sure that I'm still not understanding completely,
but why not just add UNSUPPORTED: executable_test to existing long_test test cases?

@gribozavr
Copy link
Contributor Author

but why not just add UNSUPPORTED: executable_test to existing long_test test cases?

I think doing so would disable them in, for example, check-swift-only_long-* configuration, which should run long executable tests in -Onone and long non-executable tests.

try:
config.limit_to_features.remove("executable_test")
except:
pass # It is not an error that we didn't remove anything.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: config.limit_to_features.discard("executable_test")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed!

@rintaro
Copy link
Member

rintaro commented Jun 6, 2016

but why not just add UNSUPPORTED: executable_test to existing long_test test cases?

I think doing so would disable them in, for example, check-swift-only_long-* configuration, which should run long executable tests in -Onone and long non-executable tests.

I see, thank you!

Removing an abstraction boundary also allowed me to fix a bug where we
could not run long tests in optimized mode, which prevented us from
being able to mark executable tests as long.
@gribozavr gribozavr force-pushed the cmake-test-refactor branch from 4059747 to a30f90c Compare June 6, 2016 08:02
@gribozavr
Copy link
Contributor Author

Thank you for the review!

@swift-ci Please smoke test and merge

@swift-ci swift-ci merged commit 9e8266a into master Jun 6, 2016
@gribozavr gribozavr deleted the cmake-test-refactor branch June 6, 2016 08:53
MaxDesiatov pushed a commit that referenced this pull request Apr 19, 2021
[pull] swiftwasm from main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants