Skip to content

[5.2][CodeCompletion] Use GenericSignature methods to get 'associatedtype' requirements #29104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 13, 2020
Merged

[5.2][CodeCompletion] Use GenericSignature methods to get 'associatedtype' requirements #29104

merged 3 commits into from
Jan 13, 2020

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jan 9, 2020

Cherry-pick of #29086 into swift-5.2-branch originally reviewed by @slavapestov

rdar://problem/57245073

rintaro added 3 commits January 9, 2020 14:39
@rintaro
[CodeCompletion] Get associatedtype constraints from ProtocolDecl::ge…
3ba745c 
…tRequirementSignature()

instead of AssociatedTypeDecl::getInherited() when checking if the
return type should be suggested as "opaque result type" in override
completion.

AssociatedTypeDecl::getInherited() is not serialized. So if the protocol
is declared in a module, it was never suggested as 'some' result.

rdar://problem/57245073
(cherry picked from commit e388c4a)
@rintaro
[CodeCompletion] Stop suggesting opaque result type for generic function
152e428 
in override completion. As per SE-0244:

> Associated type inference can only infer an opaque result type for a
> non-generic requirement, because the opaque type is parameterized by
> the function's own generic arguments

(cherry picked from commit 1dd6fe5)
@rintaro
[CodeCompletion] Use GenericSignature methods to get associatedtype reqs
ef628f2 
(cherry picked from commit b9f1e58)
@rintaro rintaro requested a review from a team as a code owner January 9, 2020 22:46
@rintaro
Copy link
Member Author

rintaro commented Jan 9, 2020

@swift-ci Please test

@rintaro rintaro mentioned this pull request Jan 10, 2020
Merged
@DougGregor DougGregor merged commit dce5ddc into swiftlang:swift-5.2-branch Jan 13, 2020
@rintaro rintaro deleted the 5.2-ide-completion-opaqueresult-rdar57245073 branch January 13, 2020 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rintaro @DougGregor