[build] Check for unicode functions in libedit #29115
Merged
+15
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @compnerd |
compnerd
requested changes
Jan 10, 2020
Some versions of libedit may have histedit.h but not the Unicode functions. Explicitly check for the Unicode functions in the found libedit to ensure the check is accurate. I considered making this a component of the LibEdit package in our find module, but CMake's documentation [1] says "Packages that find multiple semi-independent parts (like bundles of libraries) should search for the components...", and the "multiple semi-independent parts" definitely isn't the case here; we're just interested in determining if the found library supports a particular feature. [1] https://cmake.org/cmake/help/v3.16/manual/cmake-developer.7.html#find-modules
|
I have no idea how to clear the changes requested state, but I've updated and addressed the comments. |
compnerd
approved these changes
Jan 10, 2020
|
@swift-ci please test and merge |
|
Test failure looks unrelated. |
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some versions of libedit may have histedit.h but not the Unicode
functions. Explicitly check for the Unicode functions in the found
libedit to ensure the check is accurate.
I considered making this a component of the LibEdit package in our find
module, but CMake's documentation [1] says "Packages that find multiple
semi-independent parts (like bundles of libraries) should search for the
components...", and the "multiple semi-independent parts" definitely
isn't the case here; we're just interested in determining if the found
library supports a particular feature.
[1] https://cmake.org/cmake/help/v3.16/manual/cmake-developer.7.html#find-modules