Skip to content

[NFC] Adjust SILFunctionType layout to use TrailingObjects methods. #29124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2020
Merged

[NFC] Adjust SILFunctionType layout to use TrailingObjects methods. #29124

merged 1 commit into from
Jan 15, 2020

Conversation

varungandhi-apple
Copy link
Contributor

@varungandhi-apple varungandhi-apple commented Jan 10, 2020 •
edited
Loading

This makes the implementation cleaner, as well as fixes a bug in the numTrailingObjects<SILResultInfo>() method (which was unused).

(Review from any one person will do.)

@varungandhi-apple
Copy link
Contributor Author

@swift-ci please test

jckarter
jckarter reviewed Jan 10, 2020
View reviewed changes
jckarter
jckarter approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@jckarter jckarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for cleaning this up!

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - ed93d85058b68f79e1d3d3e89e668d06f22625b6

@varungandhi-apple
Copy link
Contributor Author

Failure seems to be due to another commit which got bundled in for testing.

@swift-ci please clean test Linux platform

@varungandhi-apple
Copy link
Contributor Author

Accidentally wrote numTrailingObjects(CanType) instead of numTrailingObjects(OverloadToken<CanType>). Oops, fixed.

@swift-ci please test and merge

@varungandhi-apple
Copy link
Contributor Author

@swift-ci please test

@swift-ci

This comment has been minimized.

Sign in to view
@swift-ci

This comment has been minimized.

Sign in to view
@varungandhi-apple
Copy link
Contributor Author

@swift-ci please test macOS platform

rjmccall
rjmccall reviewed Jan 13, 2020
View reviewed changes
Copy link
Contributor

@rjmccall rjmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks great, thanks for cleaning this up. Two minor comments, both just cleaning up things that should've been cleaner in the original code.

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - e52b7226f7856d3948af15ad60235fbe6ab01881

@varungandhi-apple
[NFC] Adjust SILFunctionType layout to use TrailingObjects methods.
bd2ea82 
This makes the implementation cleaner, as well as fixes a bug in the
numTrailingObjects<SILResultInfo> method (which was unused).
@varungandhi-apple
Copy link
Contributor Author

@swift-ci please test and merge

@varungandhi-apple
Copy link
Contributor Author

@swift-ci please test

@swift-ci

This comment has been minimized.

Sign in to view
@swift-ci

This comment has been minimized.

Sign in to view
@varungandhi-apple varungandhi-apple merged commit 4f10b19 into swiftlang:master Jan 15, 2020
@varungandhi-apple varungandhi-apple deleted the vg-adjust-SILFunctionType-layout branch January 15, 2020 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjmccall rjmccall rjmccall left review comments

@jckarter jckarter jckarter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@varungandhi-apple @swift-ci @jckarter @rjmccall