[Incremental] Dependency fixes in preparation for fine-grained dependencies #29126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test windows |
|
@swift-ci please smoke test |
|
@swift-ci please test asan |
|
@swift-ci please test windows |
|
@swift-ci please smoke test |
|
@swift-ci please test windows |
1 similar comment
|
@swift-ci please test windows |
added 4 commits
January 11, 2020 21:57
Restructure fine-grained-dependencies to enable unit testing Get frontend to emit correct swiftdeps file (fine-grained when needed) and only emit dot file for -emit-fine-grained-dependency-sourcefile-dot-files Use deterministic order for more information outputs. Set EnableFineGrainedDependencies consistently in frontend. Tolerate errors that result in null getExtendedNominal() Fix memory issue by removing node everywhere. Break up print routine Be more verbose so it will compile on Linux. Sort batchable jobs, too.
davidungar
force-pushed
the
fine-grained-fixes-rb2-w-dbg
branch
from
dce7d6f to
631c2d4
Compare
|
@swift-ci please test windows |
|
@swift-ci please smoke test |
|
@swift-ci please test Windows |
|
@swift-ci please test Windows |
|
May have also fixed rdar://58417173. Since that was an intermittent test failure on ci, it's hard to know for sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revisiting 29009, which got reverted for a Windows bug
29009 has been through review with @CodaFi