Skip to content

test: fix the prespecialized metadata tests #29150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2020

Conversation

compnerd
Copy link
Member

This loosens the overly fitted patterns and makes them much more
legible. Unfortunately, the parent VWT is referenced differently and
has been dropped here to actually allow the test to pass on all targets.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd
Copy link
Member Author

CC: @nate-chandler
This loosens the test in a few cases because they are overly constrained and I dont know if the parent VWT reference is material. If it is, you could tighten the test in a follow up.

@compnerd
Copy link
Member Author

@swift-ci please smoke test

@nate-chandler
Copy link
Contributor

nate-chandler commented Jan 11, 2020

@compnerd Thank you very much for these changes! The whitespace changes alone are extremely nice.

A couple of quick questions:

Again, thank you very much for taking care of these tests on Windows!

@compnerd
Copy link
Member Author

Yeah, the $sBi8_WV are not present on Windows. The reason for that is that the reference for the i8 type will be resolved at runtime due to the lazy resolution since you cannot have data references initialization to module-external symbols since they must be indirected through the IAT on PE/COFF (similar to indirecting through the GOT on MachO/ELF).

The only things which are not being checked for now are:

The parent reference is formed by indirecting through the VWT for the type on PE/COFF rather than having a global that you can reference (again for the same reason as above).

This loosens the overly fitted patterns and makes them much more
legible.  Unfortunately, the parent VWT is referenced differently and
has been dropped here to actually allow the test to pass on all targets.
@compnerd
Copy link
Member Author

@swift-ci please smoke test

@nate-chandler
Copy link
Contributor

Understood. Thank you for the explanation!

@compnerd compnerd merged commit 0d87a14 into swiftlang:master Jan 11, 2020
@compnerd
Copy link
Member Author

You’re welcome :). Thanks for taking a look at the changes!

@compnerd compnerd deleted the vwt-cleanups branch January 12, 2020 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants