Optimize getter keypath patterns #29160
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoecarver
commented
Jan 12, 2020
| const KeyPathPatternComponent &comp) { | ||
| assert(comp.getKind() == KeyPathPatternComponent::Kind::GettableProperty); | ||
|
|
||
| if (!addr->getType().getStructOrBoundGenericStruct() && |
There was a problem hiding this comment.
I don't really understand why this is (or would be) needed but I left it in just in case.
|
I think this is already addressed by #28799 |
|
@theblixguy thanks for pointing that out. That patch is much more comprehensive. Closing in favor of #28799 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch reworks the
createKeypathProjectionsfunction so that it can handle multiple kinds of keypath components. It also adds support for projecting getter keypaths (i.e. subscripts).