Allow function builder attrs on vars without bodies in interfaces #29165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check for whether or not we can use a function builder on a property checked whether the attached getter had a body, which is not always true for module interfaces. Just disable that part of the check when compiling a module interface. rdar://58535753
|
@swift-ci please smoke test |
|
Does the function builder actually change the interface of the VarDecl? What if we skipped printing it altogether? |
|
Also totally an option, and honestly, probably the better one. |
|
Chatted with Slava offline, since we also need to support existing, shipped interfaces, this is the best option now. |
slavapestov
approved these changes
Jan 13, 2020
|
Yep! rdar://58544718 |
|
I’ll cherry pick this to 5.2 later today |
harlanhaskins
pushed a commit
to harlanhaskins/swift
that referenced
this pull request
Jan 14, 2020
…iftlang#29165) The check for whether or not we can use a function builder on a property checked whether the attached getter had a body, which is not always true for module interfaces. Just disable that part of the check when compiling a module interface. rdar://58535753
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check for whether or not we can use a function builder on a property
checked whether the attached getter had a body, which is not always true for
module interfaces. Just disable that part of the check when compiling a
module interface.
rdar://58535753