Skip to content

[Diagnostics] Port diagnostics for array/dictionary literals #29166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 14, 2020

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Jan 13, 2020

CollectionElementContextualMismatch covers almost all of the related diagnostics
already with a single exception - generic argument mismatches which has been "fixed"
already just didn't have a diagnostic support.

@xedin xedin requested a review from hborla January 13, 2020 20:45
@xedin
Copy link
Contributor Author

xedin commented Jan 13, 2020

@swift-ci please smoke test

@xedin
Copy link
Contributor Author

xedin commented Jan 13, 2020

@swift-ci please smoke test

Copy link
Member

@hborla hborla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@xedin xedin merged commit 20443ad into swiftlang:master Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants