Sema: Fix crash when synthesizing RawRepresentable conformance with non-Equatable raw type #29173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
Looks like this should fix SR-6897 as well. Also, can you try this test case: struct S : ExpressibleByStringLiteral {
init(stringLiteral: String) {}
}
enum E: S {
case a
typealias RawValue = S
init?(rawValue: Int) { self = .a }
var rawValue: Int { 0 }
}? It used to crash for me when I was working on #27050. |
|
Ah, I forgot about #27050. I think this fix supersedes it since it centralizes the 'can derive' check. I'll add your test case too, thanks! |
…on-Equatable raw type The error recovery logic around derived conformances is a little bit tricky. Make sure we don't crash if a type explicitly provides a RawValue type witness that is not equatable, but omits the witnesses for init(rawValue:) and the rawValue property. Fixes <rdar://problem/58127114>.
slavapestov
force-pushed
the
enum-raw-value-not-equatable-fix
branch
from
21fe869 to
1dd527e
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error recovery logic around derived conformances is a little bit
tricky. Make sure we don't crash if a type explicitly provides a
RawValue type witness that is not equatable, but omits the witnesses
for init(rawValue:) and the rawValue property.
Fixes https://bugs.swift.org/browse/SR-6897, rdar://problem/58127114.