AST: Weak-link declarations in extensions of weak-linked types #29184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntend jobs Unless you do this, the flag has no effect when used with the driver; it only worked in conjunction with -Xfrontend. Noticed while working on <rdar://problem/58490723>.
This is a workaround to fix weak linking of frameworks that define types with availability, but then define extensions of those types without availability. This can come up if the framework itself is built with a newer deployment target than the client that uses the framework. Since the type checker only enforces that an extension has availability if the extension is less available than the deployment target, we were failing to weak link the members of the extension in this case. This is not a perfect fix; ideally such frameworks should be built with -require-explicit-availability, and all reported warnings fixed by adding explicit availability. However, it allows clients to weak link when using existing swiftinterface files that have already shipped in the mean time, and it should not cause any problems once the frameworks are properly annotated in the future. Fixes <rdar://problem/58490723>.
|
@swift-ci Please smoke test |
|
👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround to fix weak linking of frameworks that define
types with availability, but then define extensions of those types
without availability.
This can come up if the framework itself is built with a newer
deployment target than the client that uses the framework. Since the
type checker only enforces that an extension has availability if
the extension is less available than the deployment target, we were
failing to weak link the members of the extension in this case.
This is not a perfect fix; ideally such frameworks should be built
with -require-explicit-availability, and all reported warnings
fixed by adding explicit availability.
However, it allows clients to weak link when using existing
swiftinterface files that have already shipped in the mean time,
and it should not cause any problems once the frameworks are properly
annotated in the future.
Fixes rdar://problem/58490723.