Accelerate deprecate split complex inits #29221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I removed SinglePrecisionComplexConversions and DoublePrecisionComplexConversions - they weren't testing any new API. 2DSinglePrecision, 2DDoublePrecision, 1DSinglePrecision, and 1DDoublePrecision have all been updated to no longer use the deprecated initializer and avoid the temporary pointer warnings.
Deprecate init(fromInputArray:realParts:imaginaryParts:) for DSPSplitComplex and DSPDoubleSplitComplex
|
@swift-ci test |
FlexMonkey
changed the title
lorentey
requested changes
Jan 16, 2020
lorentey
approved these changes
Jan 18, 2020
|
@swift-ci test |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@swift-ci test |
stephentyrone
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates the
init(fromInputArray:realParts:imaginaryParts:)forDSPSplitComplexandDSPDoubleSplitComplex.I've also updated the FFT tests to no longer use these deprecated initializers, and to replace the incorrect use of temporary pointers with
withUnsafeMutableBufferPointer.@stephentyrone