Skip to content

[Diagnostics] Emit fix-its for 'did you mean to override init(from:)/encode(to:)' diagnostics #29259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2020
Merged

[Diagnostics] Emit fix-its for 'did you mean to override init(from:)/encode(to:)' diagnostics #29259

merged 1 commit into from
Jan 17, 2020

Conversation

theblixguy
Copy link
Collaborator

Emit a fix-it for the following diagnostics:

  1. "did you mean to override 'init(from:)'?"
  2. "did you mean to override 'init(from:)' and 'encode(to:)'?"

Addresses a TODO.

@theblixguy theblixguy requested a review from xedin January 16, 2020 23:16
xedin
xedin approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@theblixguy
Copy link
Collaborator Author

@swift-ci please smoke test

@theblixguy theblixguy merged commit 1f67146 into swiftlang:master Jan 17, 2020
@theblixguy theblixguy deleted the fix/add-fix-it-for-codable-diag branch January 17, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xedin xedin xedin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theblixguy @xedin