Skip to content

[NFC][Build System: build-script] Remove the old and unused preset parser. #29264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

Rostepher
Copy link
Contributor

Removes the old, unused preset parsing code from its hiding place in swift_build_support.swift_build_support.SwiftBuildSupport. The new parser implementation has been around for nearly 2 years now and I totally forgot this was still there.

@Rostepher Rostepher requested a review from edymtt January 17, 2020 05:41
@Rostepher
Copy link
Contributor Author

@swift-ci please smoke test

@Rostepher Rostepher force-pushed the remove-old-presets-parser branch from 8a8933b to ef3db01 Compare January 17, 2020 06:20
@Rostepher
Copy link
Contributor Author

@swift-ci please smoke test

@Rostepher Rostepher force-pushed the remove-old-presets-parser branch from ef3db01 to 505b938 Compare January 17, 2020 06:48
@Rostepher
Copy link
Contributor Author

@swift-ci please smoke test

@Rostepher Rostepher force-pushed the remove-old-presets-parser branch from 505b938 to 4db3bf8 Compare January 17, 2020 07:33
@Rostepher
Copy link
Contributor Author

@swift-ci please smoke test

…set parser hidden away in swift_build_support.
@Rostepher Rostepher force-pushed the remove-old-presets-parser branch from 4db3bf8 to 7b8401c Compare January 17, 2020 08:25
@Rostepher
Copy link
Contributor Author

@swift-ci please smoke test

@Rostepher Rostepher merged commit 513c926 into swiftlang:master Jan 17, 2020
@Rostepher Rostepher deleted the remove-old-presets-parser branch January 17, 2020 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant