Skip to content

[NFC][Build System: build-script] Remove TestCase.assertNotRaises method. #29265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

Rostepher
Copy link
Contributor

Remove the dumb TestCase.assertNotRaises test method which does less than nothing as it produces right-ward drift without any meaningful semantic benefit.

…hod which does less than nothing as it produces right-ward drift without any meaningful semantic benefit.
@Rostepher Rostepher requested a review from edymtt January 17, 2020 05:44
@Rostepher
Copy link
Contributor Author

@swift-ci please smoke test

@Rostepher Rostepher changed the title [Build System: build-script] Remove TestCase.assertNotRaises method. [NFC][Build System: build-script] Remove TestCase.assertNotRaises method. Jan 17, 2020
@Rostepher Rostepher merged commit 525708e into swiftlang:master Jan 17, 2020
@Rostepher Rostepher deleted the remove-assert-not-raises branch January 17, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant