build-script-impl: reorganise the option #29280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reorders the option list. It tries to categorise them by area and then sort them alphabetically. This should help work through the list and remove the now defunct options as well as try to reduce the set of options into different build configurations that we can support and try to organise the CMake invocations properly. There is still a group of uncategorised options that should get sorted out at some point. However, this is still a huge step forward towards simplifying (and hopefully eradicating) this monstrous script.
|
@swift-ci please smoke test |
bulbazord
approved these changes
Jan 17, 2020
|
CC: @shahmishal |
|
@Rostepher @edymtt Can you please review this? |
Rostepher
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reorders the option list. It tries to categorise them by area and
then sort them alphabetically. This should help work through the list
and remove the now defunct options as well as try to reduce the set of
options into different build configurations that we can support and try
to organise the CMake invocations properly.
There is still a group of uncategorised options that should get sorted
out at some point. However, this is still a huge step forward towards
simplifying (and hopefully eradicating) this monstrous script.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.