-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[5.2][cmake] Add support for exporting frameworks/libraries into cmake exp… #29282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ort files. I think this was just an oversight. The new cmake 3.16 seems to choke if we do not add SourceKit to the exports file since there are dependencies upon it in other swift libraries. (cherry picked from commit 8d712af)
@swift-ci test |
Build failed |
@gottesmm It's not clear how changing the sourcekit cmake broke this... I'll PR test again to see what happens...
|
@swift-ci test linux |
@gottesmm this needs CCC to be merged. |
@gottesmm I'm not the right person to writeup CCC for this. Feel from to create your own PR, or attach your CCC to this one (which has passed the tests). |
--- CCC for 5.2 merge --- Original Author: Michael Gottesman Explanation: Swift's CMake communicates dependencies to downstream cmake projects via SwiftConfig.cmake. This is done by "exporting" the dependency into the config file. The exporting results in that file containing the declaration of an imported target. When the downstream cmake wants to use binaries provided by the imported target, it just includes the SwiftConfig.cmake file and gets all of the name/location it needs. Scope: Most local development machines are running cmake 3.16. All these machines will fail to build the swift-5.2-branch because it did not pickup this cmake fix from master. Risk: Zero Testing: Local build and PR test Reviewer: Ben Langmuir |
@swift-ci test |
…ort files.
I think this was just an oversight. The new cmake 3.16 seems to choke if we do
not add SourceKit to the exports file since there are dependencies upon it in
other swift libraries.
(cherry picked from commit 8d712af)