Skip to content

Add SE-0269 to the changelog #29285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 24, 2020
Merged

Conversation

Jumhyn
Copy link
Member

@Jumhyn Jumhyn commented Jan 17, 2020

This updates the changelog with the changes introduced by SE-0269.

Implemented by #23934.

@Jumhyn
Copy link
Member Author

Jumhyn commented Jan 18, 2020

@theblixguy Updated per your comment. I received an email with a comment about adding "Swift Next" to the table at the top, but don't see that comment now--is that still relevant?

@Jumhyn Jumhyn requested a review from theblixguy January 18, 2020 19:18
@theblixguy
Copy link
Collaborator

I thought I remembered seeing it in the past but I went through the diff but couldn’t find it!

@theblixguy
Copy link
Collaborator

@swift-ci please smoke test

@Jumhyn Jumhyn requested a review from theblixguy January 21, 2020 19:00
@Jumhyn
Copy link
Member Author

Jumhyn commented Jan 21, 2020

@theblixguy Heads up that I've added the swift annotation to the code block here—this should be ready.

@theblixguy
Copy link
Collaborator

@swift-ci please smoke test

Copy link
Collaborator

@theblixguy theblixguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'll tag someone from Apple to take a look as well.

@theblixguy theblixguy requested a review from beccadax January 21, 2020 19:14
Copy link
Contributor

@beccadax beccadax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo.

@Jumhyn Jumhyn requested a review from beccadax January 22, 2020 13:56
@beccadax
Copy link
Contributor

@swift-ci please smoke test

@Jumhyn
Copy link
Member Author

Jumhyn commented Jan 24, 2020

@brentdax @theblixguy Could one of you merge this?

@theblixguy theblixguy merged commit 48ba315 into swiftlang:master Jan 24, 2020
@Jumhyn
Copy link
Member Author

Jumhyn commented Jan 24, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants