Skip to content

[NFC][Build System: build-script] Update the auto-generated preset parsing tests to always supply and exhaustive set of substitutions. #29286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2020
Merged

[NFC][Build System: build-script] Update the auto-generated preset parsing tests to always supply and exhaustive set of substitutions. #29286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion utils/build_swift/tests/test_driver_arguments.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

from . import expected_options as eo
from . import utils
from .test_presets import PRESET_DEFAULTS
from .utils import TestCase, UTILS_PATH, redirect_stdout
from ..build_swift import argparse
from ..build_swift import driver_arguments
Expand Down Expand Up @@ -41,7 +42,7 @@ def _load_all_presets(preset_files):

presets = dict()
for name in preset_names:
preset = parser.get_preset(name, raw=True)
preset = parser.get_preset(name, vars=PRESET_DEFAULTS)
args = migration.migrate_swift_sdks(preset.format_args())

presets[name] = args
Expand Down