[AutoDiff] Add JVPs for tgmath functions. #29290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add JVPs for tgmath functions except `remainder(_:_:)` and `fmod(_:_:)`. Add tests. JVP/VJP functions for unary tgmath functions are identical, but there is no way to register a derivative function as both a JVP/VJP of the same original function. TF-1111 tracks this; the issue will naturally resolve when linear functions and transposition are done and VJPs are removed. Partially resolves TF-1108.
|
@swift-ci Please test tensorflow |
rxwei
approved these changes
Jan 18, 2020
|
@swift-ci Please test tensorflow macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add JVPs for tgmath functions except
remainder(_:_:)andfmod(_:_:).Add tests.
JVP/VJP functions for unary tgmath functions are identical, but there is no way
to register a derivative function as both a JVP/VJP of the same original
function. TF-1111 tracks this; the issue will naturally resolve when linear
functions and transposition are done and VJPs are removed.
Partially resolves TF-1108.
Sorry, I shouldn't have taken on this starter issue. I started setting up the skeleton (with
fatalErrors) and got carried away.The TF-1107 master issue tracks other JVP definition starter issues.