Skip to content

build: always report the status of building _Differentiation #29299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2020

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Jan 18, 2020

This moves the build configuration information into the block which
prints the full configuration details for the Swift runtime. Simplify
the condition by merging the two blocks for building the standard
library and the _Differentiation module.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd
Copy link
Member Author

@swift-ci please smoke test

@compnerd
Copy link
Member Author

CC: @dan-zheng

@dan-zheng dan-zheng requested a review from rxwei January 18, 2020 17:36
This moves the build configuration information into the block which
prints the full configuration details for the Swift runtime.  Simplify
the condition by merging the two blocks for building the standard
library and the `Differentiation` module.
@compnerd
Copy link
Member Author

@swift-ci please smoke test

@rxwei rxwei changed the title build: always report the status of building Differentiation build: always report the status of building _Differentiation Jan 18, 2020
@rxwei
Copy link
Contributor

rxwei commented Jan 18, 2020

Minor correction: Differentiation module -> _Differentiation module

Copy link
Contributor

@Rostepher Rostepher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@compnerd compnerd merged commit 456ecaf into swiftlang:master Jan 19, 2020
@compnerd compnerd deleted the status branch January 19, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants