Skip to content

[NFC][Build System: build-script] Remove the old which module in swift_build_support. #29310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2020
Merged

[NFC][Build System: build-script] Remove the old which module in swift_build_support. #29310

merged 1 commit into from
Jan 20, 2020

Conversation

Rostepher
Copy link
Contributor

Removes the old which module in swift_build_support and replaces uses with the which function provided in the build_swift.shell module.

@Rostepher
Copy link
Contributor Author

@swift-ci please test

@Rostepher Rostepher changed the title [Build System: build-script] Remove the old which module in swift_build_support. [NFC][Build System: build-script] Remove the old which module in swift_build_support. Jan 19, 2020
@Rostepher Rostepher force-pushed the remove-old-which-module branch from 5727486 to 5a5f393 Compare January 19, 2020 11:41
@Rostepher
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 57274864b0f1718e88263b9a671621823c68bfeb

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 57274864b0f1718e88263b9a671621823c68bfeb

[Build System: build-script] Remove the old which module in swift_bui…
ac431fa 
…ld_support and replace uses with the which function provided in the build_swift shell module.
@Rostepher Rostepher force-pushed the remove-old-which-module branch from 5a5f393 to ac431fa Compare January 19, 2020 11:49
@Rostepher
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 5a5f393e5d95c70b146656099cce770bfb056cd3

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 5a5f393e5d95c70b146656099cce770bfb056cd3

@Rostepher
Copy link
Contributor Author

@swift-ci please test Linux platform

@Rostepher Rostepher merged commit 2d1930f into swiftlang:master Jan 20, 2020
@Rostepher Rostepher deleted the remove-old-which-module branch January 20, 2020 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edymtt edymtt Awaiting requested review from edymtt

@shahmishal shahmishal Awaiting requested review from shahmishal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rostepher @swift-ci