Fix miscellaneous warnings generated by top-of-tree clang

lib/AST/FineGrainedDependenciesSourceFileDepGraphConstructor.cpp

@@ -577,11 +577,11 @@ class SourceFileDepGraphConstructor {
 
   SourceFileDeclFinder declFinder(SF, includePrivateDeps);
     std::vector<std::pair<std::string, bool>> topLevelDepends;
-    for (const auto p: SF->getReferencedNameTracker()->getTopLevelNames())
+    for (const auto &p: SF->getReferencedNameTracker()->getTopLevelNames())
       topLevelDepends.push_back(std::make_pair(p.getFirst().userFacingName(), p.getSecond()));
 
     std::vector<std::pair<std::string, bool>> dynamicLookupDepends;
-    for (const auto p: SF->getReferencedNameTracker()->getDynamicLookupNames())
+    for (const auto &p: SF->getReferencedNameTracker()->getDynamicLookupNames())
       dynamicLookupDepends.push_back(std::make_pair(p.getFirst().userFacingName(), p.getSecond()));
 
     std::vector<std::pair<std::tuple<std::string, std::string, bool>, bool>> memberDepends;
@@ -594,27 +594,27 @@ class SourceFileDepGraphConstructor {
             declIsPrivate(p.getFirst().first)),
           p.getSecond()));
 
-      return SourceFileDepGraphConstructor(
-        swiftDeps,
-        includePrivateDeps,
-        hadCompilationError,
-
-        getInterfaceHash(SF),
-        topLevelDepends,
-        memberDepends,
-        dynamicLookupDepends,
-        depTracker.getDependencies(),
-
-        namesForProvidersOfAGivenType<NodeKind::topLevel>(declFinder.precedenceGroups),
-        namesForProvidersOfAGivenType<NodeKind::topLevel>(declFinder.memberOperatorDecls),
-        namesForProvidersOfAGivenType<NodeKind::topLevel>(declFinder.operators),
-        namesForProvidersOfAGivenType<NodeKind::topLevel>(declFinder.topNominals),
-        namesForProvidersOfAGivenType<NodeKind::topLevel>(declFinder.topValues),
-        namesForProvidersOfAGivenType<NodeKind::nominal>(declFinder.allNominals),
-        namesForProvidersOfAGivenType<NodeKind::potentialMember>(declFinder.potentialMemberHolders),
-        namesForProvidersOfAGivenType<NodeKind::member>(declFinder.valuesInExtensions),
-        namesForProvidersOfAGivenType<NodeKind::dynamicLookup>(declFinder.classMembers)
-        );
+    return SourceFileDepGraphConstructor(
+      swiftDeps,
+      includePrivateDeps,
+      hadCompilationError,
+
+      getInterfaceHash(SF),
+      topLevelDepends,
+      memberDepends,
+      dynamicLookupDepends,
+      depTracker.getDependencies(),
+
+      namesForProvidersOfAGivenType<NodeKind::topLevel>(declFinder.precedenceGroups),
+      namesForProvidersOfAGivenType<NodeKind::topLevel>(declFinder.memberOperatorDecls),
+      namesForProvidersOfAGivenType<NodeKind::topLevel>(declFinder.operators),
+      namesForProvidersOfAGivenType<NodeKind::topLevel>(declFinder.topNominals),
+      namesForProvidersOfAGivenType<NodeKind::topLevel>(declFinder.topValues),
+      namesForProvidersOfAGivenType<NodeKind::nominal>(declFinder.allNominals),
+      namesForProvidersOfAGivenType<NodeKind::potentialMember>(declFinder.potentialMemberHolders),
+      namesForProvidersOfAGivenType<NodeKind::member>(declFinder.valuesInExtensions),
+      namesForProvidersOfAGivenType<NodeKind::dynamicLookup>(declFinder.classMembers)
+      );
   }
   // clang-format on
 
@@ -652,7 +652,7 @@ class SourceFileDepGraphConstructor {
   static std::vector<ContextNameFingerprint>
   namesForProvidersOfAGivenType(std::vector<ContentsT> &contentsVec) {
     std::vector<ContextNameFingerprint> result;
-    for (const auto declOrPair : contentsVec)
+    for (const auto &declOrPair : contentsVec)
       result.push_back(ContextNameFingerprint(
           DependencyKey::computeContextForProvidedEntity<kind>(declOrPair),
           DependencyKey::computeNameForProvidedEntity<kind>(declOrPair),

lib/Driver/FineGrainedDependencyDriverGraph.cpp

@@ -543,7 +543,7 @@ void ModuleDepGraph::verifyExternalDependencyUniqueness(
 void ModuleDepGraph::verifyCanFindEachJob() const {
   FrontendStatsTracer tracer(stats,
                              "fine-grained-dependencies-verifyCanFindEachJob");
-  for (const auto p : jobsBySwiftDeps) {
+  for (const auto &p : jobsBySwiftDeps) {
     getJob(p.first);
   }
 }

lib/Driver/ParseableOutput.cpp

@@ -125,7 +125,7 @@ class DetailedCommandBasedMessage : public CommandBasedMessage {
       if (const auto *BJAction = dyn_cast<BackendJobAction>(&Cmd.getSource())) {
         Inputs.push_back(CommandInput(OutFiles[BJAction->getInputIndex()]));
       } else {
-        for (const std::string &FileName : OutFiles) {
+        for (const std::string FileName : OutFiles) {
           Inputs.push_back(CommandInput(FileName));
         }
       }
@@ -134,7 +134,7 @@ class DetailedCommandBasedMessage : public CommandBasedMessage {
     // TODO: set up Outputs appropriately.
     file_types::ID PrimaryOutputType = Cmd.getOutput().getPrimaryOutputType();
     if (PrimaryOutputType != file_types::TY_Nothing) {
-      for (const std::string &OutputFileName : Cmd.getOutput().
+      for (const std::string OutputFileName : Cmd.getOutput().
                                                  getPrimaryOutputFilenames()) {
         Outputs.push_back(OutputPair(PrimaryOutputType, OutputFileName));
       }

lib/IDE/CodeCompletion.cpp

@@ -1307,7 +1307,7 @@ class CodeCompletionCallbacksImpl : public CodeCompletionCallbacks {
                                Component->getLoc() });
       if (auto Module = Context.getLoadedModule(AccessPath))
         ParsedTypeLoc.setType(ModuleType::get(Module));
-        return true;
+      return true;
     }
     return false;
   }

lib/IRGen/GenProto.cpp

@@ -2717,7 +2717,7 @@ void NecessaryBindings::addTypeMetadata(CanType type) {
     return;
   }
   if (auto fn = dyn_cast<FunctionType>(type)) {
-    for (const auto &elt : fn.getParams())
+    for (const auto elt : fn.getParams())
       addTypeMetadata(elt.getPlainType());
     addTypeMetadata(fn.getResult());
     return;

lib/IRGen/MetadataPath.h

@@ -183,7 +183,7 @@ class MetadataPath {
   /// Return an abstract measurement of the cost of this path.
   OperationCost cost() const {
     auto cost = OperationCost::Free;
-    for (const Component &component : Path)
+    for (const Component component : Path)
       cost += component.cost();
     return cost;
   }

lib/SIL/DynamicCasts.cpp

@@ -1161,9 +1161,9 @@ bool swift::canUseScalarCheckedCastInstructions(SILModule &M,
     if (!objectType.isAnyClassReferenceType())
       return false;
 
-      auto super = archetype->getSuperclass();
-      if (super.isNull())
-        return false;
+    auto super = archetype->getSuperclass();
+    if (super.isNull())
+      return false;
 
     // A base class constraint that isn't NSError rules out the archetype being
     // bound to NSError.

lib/SILOptimizer/Mandatory/DIMemoryUseCollector.cpp

@@ -258,7 +258,6 @@ SILValue DIMemoryObjectInfo::emitElementAddressForDestroy(
             // If we have a class, we can use a borrow directly and avoid ref
             // count traffic.
             if (isa<ClassDecl>(NTD) && Ptr->getType().isAddress()) {
-              SILValue Original = Ptr;
               SILValue Borrowed = Ptr = B.createLoadBorrow(Loc, Ptr);
               EndScopeList.emplace_back(Borrowed, EndScopeKind::Borrow);
             }

lib/SILOptimizer/Mandatory/MandatoryInlining.cpp

@@ -598,7 +598,7 @@ getCalleeFunction(SILFunction *F, FullApplySite AI, bool &IsThick,
   FullArgs.clear();
 
   // First grab our basic arguments from our apply.
-  for (const auto &Arg : AI.getArguments())
+  for (const auto Arg : AI.getArguments())
     FullArgs.push_back(Arg);
 
   // Then grab a first approximation of our apply by stripping off all copy

lib/SILOptimizer/SILCombiner/SILCombinerMiscVisitors.cpp

@@ -1284,9 +1284,9 @@ SILInstruction *SILCombiner::visitCondBranchInst(CondBranchInst *CBI) {
       X->getType() ==
           SILType::getBuiltinIntegerType(1, CBI->getModule().getASTContext())) {
     SmallVector<SILValue, 4> OrigTrueArgs, OrigFalseArgs;
-    for (const auto &Op : CBI->getTrueArgs())
+    for (const auto Op : CBI->getTrueArgs())
       OrigTrueArgs.push_back(Op);
-    for (const auto &Op : CBI->getFalseArgs())
+    for (const auto Op : CBI->getFalseArgs())
       OrigFalseArgs.push_back(Op);
     return Builder.createCondBranch(CBI->getLoc(), X,
                                     CBI->getFalseBB(), OrigFalseArgs,

lib/SILOptimizer/UtilityPasses/SerializeSILPass.cpp

@@ -131,7 +131,7 @@ static bool hasOpaqueArchetypeOperand(TypeExpansionContext context,
 static bool hasOpaqueArchetypeResult(TypeExpansionContext context,
                                      SILInstruction &inst) {
   // Check the results for opaque types.
-  for (const auto &res : inst.getResults())
+  for (const auto res : inst.getResults())
     if (opaqueArchetypeWouldChange(context, res->getType().getASTType()))
       return true;
   return false;

lib/SILOptimizer/Utils/SILInliner.cpp

@@ -350,7 +350,7 @@ SILInliner::inlineFullApply(FullApplySite apply,
                             SILOptFunctionBuilder &funcBuilder) {
   assert(apply.canOptimize());
   SmallVector<SILValue, 8> appliedArgs;
-  for (const auto &arg : apply.getArguments())
+  for (const auto arg : apply.getArguments())
     appliedArgs.push_back(arg);
 
   SILFunction *caller = apply.getFunction();

stdlib/public/Reflection/TypeRefBuilder.cpp

@@ -447,7 +447,7 @@ void ClosureContextInfo::dump(FILE *file) const {
 
 void TypeRefBuilder::dumpCaptureSection(FILE *file) {
   for (const auto &sections : ReflectionInfos) {
-    for (const auto &descriptor : sections.Capture) {
+    for (const auto descriptor : sections.Capture) {
       auto info = getClosureContextInfo(descriptor);
       info.dump(file);
     }