[Typechecker] Remove 'NSObject.hashValue' warning now that hashValue is no longer marked 'open' #29314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
Jenkins keeps erroring out due to "invalid SHA" and kicks off a new build but it doesn't show up here 🤷♂ I'll let it run and see what happens. |
|
Let’s try again: @swift-ci please clean smoke test |
|
:/ @swift-ci please smoke test |
|
cc @shahmishal do you have any idea why the CI keeps failing the build ("invalid SHA")? |
|
@swift-ci test |
|
Build failed |
|
Build failed |
|
@swift-ci please smoke test |
|
I am not able to checkout this PR, can you close it and create a new one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is no longer required because
NSObject.hashValueis no longer markedopenin Foundation (core-libs). The current diagnostic is emitted by the typechecker incheckOverrideAccessControl(), so this is no longer needed.