EscapeAnalysis verification: fix false positives. #29316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ConnectionGraph merging triggers an assert, report which functions are being merged.
|
@swift-ci test |
|
@swift-ci test source compatibility |
|
@swift-ci benchmark |
Performance: -OCode size: -OPerformance: -OsizeCode size: -OsizePerformance: -Onone
Code size: -swiftlibsHow to read the dataThe tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.If you see any unexpected regressions, you should consider fixing the Noise: Sometimes the performance results (not code size!) contain false Hardware Overview |
Don't merge node properties until after node merging begins, so internal verification can run right before each merge. Rework ConnectionGraph::mergeFrom. Remove an extra loop. Defer mergeAllScheduledNodes until all the source graph's mapped nodes are added so that the graph is always structurally valid before a merge. This is also necessary to avoid EscapeAnalysis assert: (!To->mergeTo), in setPointsToEdge. Enable -escapes-internal-verify to all tests in escape_analysis.sil. Add hand-reduced unit tests in escape_analysis_reduced.sil.
Noticed by code inspection during debugging. This avoids some work but is probably NFC.
Noticed by code inspection during debugging. Iterator invalidaton could occur because two types of edges, which are handled independently, actually share the same phyical list. Fix the visitor utility that iterates over defer edges to be robust for visitors that change the pointsTo edge. Use a temporary vector to be safe.
Defer edges should always point to the more specific SSA value. For example, the contents of a memory location point to the values stored in that locations. Tuples point to their elements. BBArgs point to their source operands. Likewise, array objects should point to their exposed unsafe pointer (which is effectively a value stored in the array object). I'm not sure why the defer edges were reversed in the first place, but it was always confusing me.
Consistently handle base and derived pointers. Consistently avoid creating nodes for undef, which breaks verification. Be more precise about creating the node based on the derived pointer type. Remove a few extraneous helpers. Fixes <rdar://58445744> swiftc assert during EscapeAnalysis verification: (EA->isPointer(Nd->mappedValue)), function verify
|
@swift-ci test |
|
@swift-ci test source compatibility |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of EscapeAnalysis commits related to verification. It fixes some false positives while making the analysis results a bit more precise and consistent.
They are easier to review independently, but easier to push through as one PR. An open bug is waiting on the last commit in the series.
Fixes rdar://58445744 swiftc assert during EscapeAnalysis verification: (EA->isPointer(Nd->mappedValue)), function verify