Skip to content

[Typechecker] Remove 'NSObject.hashValue' warning now that hashValue is no longer marked 'open' #29328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2020
Merged

[Typechecker] Remove 'NSObject.hashValue' warning now that hashValue is no longer marked 'open' #29328

merged 1 commit into from
Jan 21, 2020

Conversation

theblixguy
Copy link
Collaborator

This code is no longer required because NSObject.hashValue is no longer marked open in Foundation (core-libs). The current diagnostic is emitted by the typechecker in checkOverrideAccessControl(), so this is no longer needed.

…rror (and because 'hashValue' is longer 'open')
@theblixguy
Copy link
Collaborator Author

@swift-ci please smoke test

@theblixguy theblixguy requested a review from xedin January 21, 2020 19:44
@theblixguy theblixguy merged commit 451074a into swiftlang:master Jan 21, 2020
@theblixguy theblixguy deleted the chore/remove-old-hashvalue-warning branch January 21, 2020 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants