[Take 2] Reimplement function builders as statement transformations #29331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ations. ASTScopes completely skip implicit pattern bindings, so don't mark generated ones as implicit. Instead, give them suitable source location information. Fixes rdar://problem/58710568.
…ariables. Collect all references to parameters whose types involve type variables, including in closures that aren’t single-expression. This fixes a type checker assertion that occurs when the constraint graph can get disconnected with the combination of delayed constraint generation for single-expression closures and the use of function builders. Fixes rdar://problem/58695803.
DougGregor
changed the title
|
@swift-ci please smoke test |
This was referenced Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the implementation of function builders so they maintain the statement structure of the closure/function body to which they are applied. This replaces the previous "fold everything into a single expression" implementation with one that is better in several regards:
buildBlock/buildExpression/buildIf/etc. invocation. The result is easier to reason about.if let, although each of these will require work.This refactoring is a major step toward generalizing function builders (rdar://problem/50426203) and fixes a related issue with delaying constraints for single-expression closures (rdar://problem/58695803).