build-script: add missing options, use more terse syntax #29334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
Rostepher
reviewed
Jan 21, 2020
Rostepher
reviewed
Jan 21, 2020
This makes the product computation more terse and adds the missing options. The functional aspects of this change include renaming the `SKIP_BUILD_SWIFT_STATIC_LIBDISPATCH` to `SKIP_BUILD_STATIC_LIBDISPATCH` which keeps it in line with the other skip options. We also now list the option properly.
compnerd
force-pushed
the
bs-product-computation
branch
from
6094506 to
1aafd55
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the product computation more terse and adds the missing
options. The functional aspects of this change include renaming the
SKIP_BUILD_SWIFT_STATIC_LIBDISPATCHtoSKIP_BUILD_STATIC_LIBDISPATCHwhich keeps it in line with the other skip options. We also now list
the option properly.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.