[AST|ASTWalker] Fix assertion hit walking an invalid AST with a protocol decl inside an extension #29338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…col decl inside an extension The AST walker calling getGenericParams on a protocol decl would eventually call computeNominalType. computeNominalType checks that the protocol (as a nomimnal type decl) appears within a type context, and if so, asks for the SelfNominalTypeDecl of that context. If the context is an extension, that ends up asking for its extended nominal, which is a problem if we're walking a pre-typechecked AST – we hit the assertion "Extension must have already been bound (by bindExtensions)"). Unlike other nominal types, it's not valid Swift for protocols to appear within type contexts, so exclude protocol decls from taking this code path. This results in us providing Type() as the parent type of the produced NominalType, just like we do for protocols inside functions or other invalid contexts. Resolves <rdar://problem/58549036>
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AST walker calling
getGenericParams()on a protocol decl would eventually callcomputeNominalType.computeNominalTypechecks that the protocol (as a nominal type decl) appears within a type context, and if so, asks for theSelfNominalTypeDeclof that context. If the context is an extension, that ends up asking for its extended nominal, which is a problem if we're walking a pre-typechecked AST – we hit the assertion "Extension must have already been bound (by bindExtensions)").Unlike other nominal types, it's not valid Swift for protocols to appear within type contexts, so exclude protocol decls from taking this code path. This results in us providing
Type()as the parent type of the producedNominalType, just like we do for protocols inside functions or other invalid contexts.Resolves rdar://problem/58549036