build-script: generate options (NFC) #29342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
Rostepher
reviewed
Jan 22, 2020
| libicu-cmake-options "" "CMake options used for all libicu targets" | ||
| llbuild-cmake-options "" "CMake options used for all llbuild targets" | ||
| lldb-cmake-options "" "CMake options used for all lldb targets" | ||
| llvm-cmake-options "" "CMake options used for all llvm targets" | ||
| ninja-cmake-options "" "CMake options used for all ninja targets" |
There was a problem hiding this comment.
Huh, looks like ninja has a duplicate option here. Not that we need to fix it in this PR, just pointing it out.
There was a problem hiding this comment.
Yeah, I realized that too, and will remove that in a follow up. This is part of the motivation of re-structuring the options - it allows the opportunity to clean this up.
Rostepher
reviewed
Jan 22, 2020
Rather than individually list the options, generate the options which ensures that options are more uniform and makes it easier to alter them globally.
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux platform |
Rostepher
approved these changes
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than individually list the options, generate the options which
ensures that options are more uniform and makes it easier to alter them
globally.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.