[sourcekit] Add global -module-cache-path to test executables #29357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a global -module-cache-path option to `sourcekitd-test` and `complete-test` and have lit provide the default module cache in its substitutions. Previously many tests have explicitly provided the `%mcp_opt` option, but this is easy to forget when writing new tests. The module cache is inserted into the compiler arguments at the beginning so that it's still possible for a test to override it with a per-test cache if desired. rdar://58752842
Remove `%mcp_opt` from commands that use `%sourcekitd-test` and `%complete-test`, as they are now redundant with the lit substitution.
|
@swift-ci please test |
This was referenced Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a global -module-cache-path option to
sourcekitd-testandcomplete-testand have lit provide the default module cache in itssubstitutions. Previously many tests have explicitly provided the
%mcp_optoption, but this is easy to forget when writing new tests.The module cache is inserted into the compiler arguments at the
beginning so that it's still possible for a test to override it with a
per-test cache if desired.
rdar://58752842