Skip to content

[ConstraintSystem] Finish porting member failure diagnostics #29360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 22, 2020

Conversation

hborla
Copy link
Member

@hborla hborla commented Jan 22, 2020

  • Remove special cases for AnyObject member and dynamic member lookup failures - these are now all handled in the new diagnostic infrastructure.
  • Find solutions for code that contains circular member references in the new diagnostic infrastructure.
  • Remove dead code from CalleeCandidateInfo

Remove special cases for AnyObject member and dynamic member lookup
failures - these are now all handled in the new diagnostic
infrastructure.
references in the new diagnostic infrastructure.
@hborla hborla requested review from xedin and CodaFi January 22, 2020 20:12
@hborla
Copy link
Member Author

hborla commented Jan 22, 2020

@swift-ci please smoke test

Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@hborla hborla merged commit 26f0924 into swiftlang:master Jan 22, 2020
@hborla hborla deleted the finish-member-failures branch January 22, 2020 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants