Skip to content

build: add support for optionally building PythonKit #29366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2020
Merged

build: add support for optionally building PythonKit #29366

merged 1 commit into from
Jan 25, 2020

Conversation

compnerd
Copy link
Member

This adds support for building PythonKit as a package as part of the
toolchain build.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd
Copy link
Member Author

CC: @shahmishal @Rostepher @edymtt @rxwei @dan-zheng

@compnerd
Copy link
Member Author

@swift-ci please clean test

shahmishal
shahmishal approved these changes Jan 22, 2020
View reviewed changes
Copy link
Member

@shahmishal shahmishal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shahmishal
Copy link
Member

Can you add few tests for the new flag?

@Rostepher
Copy link
Contributor

Rostepher commented Jan 22, 2020 •
edited
Loading

You can run the Python unit tests and lint via:

python utils/python_lint.py
python utils/build_swift/run_tests.py  # There are other flags as well, try --help
python utils/swift_build_support/run_tests.py
python utils/update_checkout/run_tests.py

Running the build_swift tests with python3 will enable some extra testing.

Rostepher
Rostepher reviewed Jan 22, 2020
View reviewed changes
@compnerd compnerd force-pushed the optional-pythonkit-support branch from 4f58b7e to 648ab5f Compare January 23, 2020 00:16
@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 4f58b7e47c3bdd096e9a333142a339dfe3964b16

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 4f58b7e47c3bdd096e9a333142a339dfe3964b16

@compnerd
Copy link
Member Author

@swift-ci please clean test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 4f58b7e47c3bdd096e9a333142a339dfe3964b16

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 4f58b7e47c3bdd096e9a333142a339dfe3964b16

@compnerd
build: add support for optionally building PythonKit
cad0c7a 
This adds support for building PythonKit as a package as part of the
toolchain build.
@compnerd compnerd force-pushed the optional-pythonkit-support branch from 648ab5f to cad0c7a Compare January 24, 2020 19:17
@compnerd
Copy link
Member Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 648ab5f0cb9666d31d149457ec405b05481fe83f

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 648ab5f0cb9666d31d149457ec405b05481fe83f

@compnerd
Copy link
Member Author

@swift-ci please smoke test Linux platform

1 similar comment
@compnerd
Copy link
Member Author

@swift-ci please smoke test Linux platform

@compnerd compnerd merged commit e26b216 into swiftlang:master Jan 25, 2020
@compnerd compnerd deleted the optional-pythonkit-support branch January 25, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rostepher Rostepher Rostepher approved these changes

@shahmishal shahmishal shahmishal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@compnerd @shahmishal @Rostepher @swift-ci