Skip to content

build: cleanup unreferenced CMake variables #29371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2020
Merged

build: cleanup unreferenced CMake variables #29371

merged 1 commit into from
Jan 23, 2020

Conversation

compnerd
Copy link
Member

SWIFT_CMARK_LIBRARY_DIR is not referenced in the build, remove the
variable.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd
build: cleanup unreferenced CMake variables
a3a88dd 
`SWIFT_CMARK_LIBRARY_DIR` is not referenced in the build, remove the
variable.
@compnerd
Copy link
Member Author

CC: @Rostepher @edymtt @xiaobai

Rostepher
Rostepher approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@Rostepher Rostepher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Rostepher
Copy link
Contributor

@swift-ci please test

@compnerd compnerd merged commit 4356e95 into swiftlang:master Jan 23, 2020
@compnerd compnerd deleted the bs-dead-variables branch January 23, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rostepher Rostepher Rostepher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@compnerd @Rostepher