[CodeCompletion] Ignore implicit decl when finding equivalent decl #29377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TypeChecker sometimes (e.g. property wrappers) inserts implicit decls (e.g. 'PatternBindingDecl's and 'VarDecl's) between decls in the AST. This used to confuse 'getEquivalentDeclContextFromSourceFile()'. It canceled fast-completion, caused crashes, or completed in a wrong context. Ignore implicit decls in the AST so that we can find the correct decl context. rdar://problem/58665268
rintaro
force-pushed
the
ide-completion-rdar58665268
branch
from
ba77b2e to
7b4466f
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeChecker sometimes (e.g property wrappers) inserts implicit decls (e.g.
PatternBindingDecls andVarDecls) between the decl in the AST. This used to confusegetEquivalentDeclContextFromSourceFile(). It canceled fast-completion, caused crashes, or completed in a wrong context.Ignore implicit decls in the AST so that we can find the correct decl context.
rdar://problem/58665268