utils: change handling of generic specializations in analyze_code_size.py #29382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e.py Two changes: * If a function is a function signature (or any other) specialization of a generic specialization, count it is generic specialization. Function signature speializations are just small modifications of the original function, whereas generic specializations are real copies. So it makes more sense to "prioritize" generic specializations. * Create a separate category of generic specializations of stdlib functions.
|
@swift-ci smoke test |
aschwaighofer
approved these changes
Jan 23, 2020
|
I think this seems to be causing
edit: should be fixed by #29395 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes:
If a function is a function signature (or any other) specialization of a generic specialization, count it is generic specialization.
Function signature speializations are just small modifications of the original function, whereas generic specializations are real copies. So it makes more sense to "prioritize" generic specializations.
Create a separate category of generic specializations of stdlib functions.