TensorFlow: switch to using CTensorFlow from swift-apis #29402
Merged
+5
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test tensorflow |
compnerd
force-pushed
the
see-tensorflow-see-tensorflow-run-run-tensorflow-run
branch
from
dadf295 to
8bed532
Compare
|
@swift-ci please test tensorflow |
|
:-( the Swift CMake implementation of CMake doesn't behave like CMake and ignores the interface linkage, Im going to revert to the old way of handling the flags. |
This adjusts the build to stop replicating the CTensorFlow module locally and instead using the version in the swift-apis repository. This more closely mimics the build as if it were out-of-tree enabling a simpler migration to building this package out-of-tree.
compnerd
force-pushed
the
see-tensorflow-see-tensorflow-run-run-tensorflow-run
branch
from
8bed532 to
eaa9937
Compare
|
@swift-ci please test tensorflow |
dan-zheng
approved these changes
Jan 24, 2020
pschuh
approved these changes
Jan 24, 2020
compnerd
deleted the
see-tensorflow-see-tensorflow-run-run-tensorflow-run
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts the build to stop replicating the CTensorFlow module
locally and instead using the version in the swift-apis repository.
This more closely mimics the build as if it were out-of-tree enabling a
simpler migration to building this package out-of-tree.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.